netdev - Re: [PATCH net v2 1/1] ipvlan: NULL pointer dereference panic in ipvlan_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171118.103729.433267100989647193.davem@davemloft.net>
Date:   Sat, 18 Nov 2017 10:37:29 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     girish.moodalbail@...cle.com
Cc:     netdev@...r.kernel.org, mahesh@...dewar.net
Subject: Re: [PATCH net v2 1/1] ipvlan: NULL pointer dereference panic in
 ipvlan_port_destroy

From: Girish Moodalbail <girish.moodalbail@...cle.com>
Date: Thu, 16 Nov 2017 23:16:17 -0800

> When call to register_netdevice() (called from ipvlan_link_new()) fails,
> we call ipvlan_uninit() (through ndo_uninit()) to destroy the ipvlan
> port. After returning unsuccessfully from register_netdevice() we go
> ahead and call ipvlan_port_destroy() again which causes NULL pointer
> dereference panic. Fix the issue by making ipvlan_init() and
> ipvlan_uninit() call symmetric.
> 
> The ipvlan port will now be created inside ipvlan_init() and will be
> destroyed in ipvlan_uninit().
> 
> Fixes: 2ad7bf363841 (ipvlan: Initial check-in of the IPVLAN driver)
> Signed-off-by: Girish Moodalbail <girish.moodalbail@...cle.com>

Applied.