netdev - Re: [PATCH 2/2] r8169: use same RTL8111EVL green settings as in vendor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171119.154454.2030592370938773133.davem@davemloft.net>
Date:   Sun, 19 Nov 2017 15:44:54 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, hau@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] r8169: use same RTL8111EVL green settings as in
 vendor driver

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 19 Nov 2017 01:36:02 +0100

> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 19f3074a0..912549c88 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -3810,6 +3810,11 @@ static void rtl8168e_2_hw_phy_config(struct rtl8169_private *tp)
>  	rtl_w0w1_phy(tp, 0x19, 0x0001, 0x0000);
>  	rtl_w0w1_phy(tp, 0x10, 0x0400, 0x0000);
>  	rtl_writephy(tp, 0x1f, 0x0000);
> +	rtl_writephy(tp, 0x1f, 0x0005);
> +	rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000);
> +	rtl_writephy(tp, 0x1f, 0x0000);
> +	/* soft-reset phy */
> +	rtl_writephy(tp, 0x00, 0x9200);

Please do not use magic constants when writing to the MII_BMCR in page
zero of the PHY.  These register offsets and register bit fields have
defines in <linux/mii.h", so please use them.