netdev - Re: [PATCH 2/2] ip6_tunnel: pass tun_dst arg from ip6_tnl_rcv() to __ip6_tnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171119.122200.1034138931090068127.davem@davemloft.net>
Date:   Sun, 19 Nov 2017 12:22:00 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     alexey.kodanev@...cle.com
Cc:     netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [PATCH 2/2] ip6_tunnel: pass tun_dst arg from ip6_tnl_rcv() to
 __ip6_tnl_rcv()

From: Alexey Kodanev <alexey.kodanev@...cle.com>
Date: Fri, 17 Nov 2017 19:16:18 +0300

> Otherwise tun_dst argument is unused there. Currently, ip6_tnl_rcv()
> invoked with tun_dst set to NULL, so there is no actual functional
> changes introduced in this patch.

Oh yes there is a functional change, becaue __ip6_tnl_rcv() is also
used by ipxip6_rcv() which can pass a non-NULL tnl_dst.

If anything, you commit log message is inaccurate and you need to
investigate the implications of this functional change.