netdev - Re: [PATCH net] net: ena: fix race condition between device reset and link up setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171120.113727.953814514175182791.davem@davemloft.net>
Date:   Mon, 20 Nov 2017 11:37:27 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     netanel@...zon.com
Cc:     netdev@...r.kernel.org, dwmw@...zon.com, zorik@...zon.com,
        matua@...zon.com, saeedb@...zon.com, msw@...zon.com,
        aliguori@...zon.com, nafea@...zon.com, evgenys@...zon.com
Subject: Re: [PATCH net] net: ena: fix race condition between device reset
 and link up setup

From: <netanel@...zon.com>
Date: Sun, 19 Nov 2017 18:03:40 +0000

> From: Netanel Belgazal <netanel@...zon.com>
> 
> In rare cases, ena driver would reset and re-start the device,
> for example, in case of misbehaving application that causes
> transmit timeout
> 
> The first step in the reset procedure is to stop the Tx traffic by
> calling ena_carrier_off().
> 
> After the driver have just started the device reset procedure, device
> happens to send an asynchronous notification (via AENQ) to the driver
> than there was a link change (to link-up state).
> This link change is mapped to a call to netif_carrier_on() which
> re-activates the Tx queues, violating the assumption of no tx traffic
> until device reset is completed, as the reset task might still be in
> the process of queues initialization, leading to an access to
> uninitialized memory.
> 
> Signed-off-by: Netanel Belgazal <netanel@...zon.com>

Applied.