netdev - Re: [PATCH net-next 1/1] forcedeth: replace pci_unmap_page with dma_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171120.113822.1280342845061896700.davem@davemloft.net>
Date:   Mon, 20 Nov 2017 11:38:22 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     yanjun.zhu@...cle.com
Cc:     tremyfr@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] forcedeth: replace pci_unmap_page with
 dma_unmap_page

From: Zhu Yanjun <yanjun.zhu@...cle.com>
Date: Sun, 19 Nov 2017 09:05:31 -0500

> @@ -1986,7 +1986,7 @@ static void nv_unmap_txskb(struct fe_priv *np, struct nv_skb_map *tx_skb)
>  					 tx_skb->dma_len,
>  					 DMA_TO_DEVICE);
>  		else
> -			pci_unmap_page(np->pci_dev, tx_skb->dma,
> +			dma_unmap_page(&np->pci_dev->dev, tx_skb->dma,
>  				       tx_skb->dma_len,
>  				       PCI_DMA_TODEVICE);

So you're going to call a dma_*() function using a PCI_DMA_* direction
flag?

Please correct this.

Thank you.