netdev - Re: Bug in socket(7) man page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAKgNAki1SVPTnRBHL9CJF2nv99XdWtfQs_OjgGCoYapNUdz2jw@mail.gmail.com>
Date:   Mon, 20 Nov 2017 12:32:49 +0100
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:     Tobias Klausmann <klausman@...warzvogel.de>
Cc:     linux-man <linux-man@...r.kernel.org>, Petr Malat <oss@...at.biz>,
        netdev <netdev@...r.kernel.org>,
        Neil Horman <nhorman@...driver.com>
Subject: Re: Bug in socket(7) man page

[CC widended]

Tobias,

On 7 August 2017 at 13:53, Tobias Klausmann <klausman@...warzvogel.de> wrote:
> Hi!
>
> This bug pertains to the manpage as visible on man7.org right
> now.
>
> The socket(7) man page has this paragraph:
>
>        SO_RXQ_OVFL (since Linux 2.6.33)
>               Indicates that an unsigned 32-bit value ancillary message (cmsg) should be attached to
>               received skbs indicating the number of packets dropped by the socket between the  last
>               received packet and this received packet.
>
> The second half is wrong: the counter (internally,
> SOCK_SKB_CB(skb)->dropcount is *not* reset after every packet.
> That is, it is a proper counter, not a gauge, in monitoring
> parlance.
>
> A better version of that paragraph:
>
>        SO_RXQ_OVFL (since Linux 2.6.33)
>               Indicates that an unsigned 32-bit value ancillary message (cmsg) should be attached to
>               received skbs indicating the number of packets dropped by the socket since its
>               creation.

Thanks for the report. See also my reply to Petr in just a moment.
I've taken your suggested text change.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/