netdev - Re: JOIN_ANYCAST breakage w. "net: ipv6: put host and anycast routes on device with address"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171120115606.GA24866@breakpoint.cc>
Date:   Mon, 20 Nov 2017 12:56:06 +0100
From:   Florian Westphal <fw@...len.de>
To:     David Ahern <dsahern@...il.com>
Cc:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Subject: Re: JOIN_ANYCAST breakage w. "net: ipv6: put host and anycast routes
 on device with address"

David Ahern <dsahern@...il.com> wrote:
> On 11/14/17 10:36 AM, Florian Westphal wrote:
> > Hi David
> > 
> > This test program no longer works with 4.14
> > (recvfrom: Resource temporarily unavailable)
> > 
> > after reverting commit
> > 4832c30d5458387ff2533ff66fbde26ad8bb5a2d
> > (net: ipv6: put host and anycast routes on device with address)
> > 
> > it will work again ("OK").
> > 
> > Could you please have a look at this?
> > 
> 
> This restores the previous behavior:
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 05eb7bc36156..1c29d9bcedc3 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1019,7 +1019,7 @@ static struct net_device
> *ip6_rt_get_dev_rcu(struct rt6_info *rt)
>  {
>         struct net_device *dev = rt->dst.dev;
> 
> -       if (rt->rt6i_flags & RTF_LOCAL) {
> +       if (rt->rt6i_flags & (RTF_LOCAL | RTF_ANYCAST)) {
>                 /* for copies of local routes, dst->dev needs to be the
>                  * device if it is a master device, the master device if
>                  * device is enslaved, and the loopback as the default

Looks like it, thanks David!