netdev - Re: [PATCH RFC 0/5] Support asynchronous crypto for IPsec GSO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171120.220922.840932981327545918.davem@davemloft.net>
Date:   Mon, 20 Nov 2017 22:09:22 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     steffen.klassert@...unet.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH RFC 0/5] Support asynchronous crypto for IPsec GSO.

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Mon, 20 Nov 2017 08:37:47 +0100

> This patchset implements asynchronous crypto handling
> in the layer 2 TX path. With this we can allow IPsec
> ESP GSO for software crypto. This also merges the IPsec
> GSO and non-GSO paths to both use validate_xmit_xfrm().
 ...

Code looks generally fine to me.  Only thing of note is that this
adds a new dev_requeue_skb() call site and that might intersect with
John Fastabend's RFC work to make qdiscs lockless.

Also, please adhere to the reverse christmas tree rule for the
ordering of your function local variables.

Thank you.