netdev - Re: [patch net] mlxsw: spectrum: Do not try to create non-existing ports during unsplit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171121.201551.50423381159309300.davem@davemloft.net>
Date:   Tue, 21 Nov 2017 20:15:51 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum: Do not try to create non-existing
 ports during unsplit

From: Jiri Pirko <jiri@...nulli.us>
Date: Tue, 21 Nov 2017 09:42:21 +0100

> From: Ido Schimmel <idosch@...lanox.com>
> 
> On some systems, when we unsplit a port we need to re-create two ports
> instead. On other systems, only one needs to be re-created.
> 
> Do not try to create a port if during driver initialization it was
> assigned a negative module number, which is invalid.
> 
> This avoids the following error during unsplit:
> [  941.012478] mlxsw_spectrum 0000:01:00.0: Port 43: Failed to map module
> 
> The error is harmless and caused by the fact that a local port is
> already mapped to module 0.
> 
> Fixes: be94535f9531 ("mlxsw: spectrum: Make split flow match firmware requirements")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Arkadi Sharshevsky <arkadis@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied.