netdev - Re: [PATCH net] bpf: change bpf_probe_write_user to bpf_trace_printk in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4954ebc-983c-ba4f-12db-ecb6438a8644@iogearbox.net>
Date:   Tue, 21 Nov 2017 21:35:34 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, ast@...com, netdev@...r.kernel.org
Cc:     kernel-team@...com
Subject: Re: [PATCH net] bpf: change bpf_probe_write_user to bpf_trace_printk
 in test_verifier

On 11/21/2017 08:23 PM, Yonghong Song wrote:
> There are four tests in test_verifier using bpf_probe_write_user
> helper. These four tests will emit the following kernel messages
>   [   12.974753] test_verifier[220] is installing a program with bpf_probe_write_user
>                                     helper that may corrupt user memory!
>   [   12.979285] test_verifier[220] is installing a program with bpf_probe_write_user
>                                     helper that may corrupt user memory!
>   ......
> 
> This may confuse certain users. This patch replaces bpf_probe_write_user
> with bpf_trace_printk. The test_verifier already uses bpf_trace_printk
> earlier in the test and a trace_printk warning message has been printed.
> So this patch does not emit any more kernel messages.
> 
> Signed-off-by: Yonghong Song <yhs@...com>

Applied to bpf tree, thanks Yonghong!