lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Nov 2017 14:04:07 -0800 From: Randy Dunlap <rdunlap@...radead.org> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, linux-bluetooth@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro On 11/22/2017 01:15 PM, Andy Shevchenko wrote: > This macro deduplicates a lot of similar code across the hci_debugfs.c > module. Targeting to be moved to seq_file.h eventually. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > --- > net/bluetooth/hci_debugfs.c | 184 +++++--------------------------------------- > 1 file changed, 18 insertions(+), 166 deletions(-) Looks like a good idea, but below, there is a use of DEFINE_SHOW_ATTRIBUTE() before it is #defined. > diff --git a/net/bluetooth/hci_debugfs.c b/net/bluetooth/hci_debugfs.c > index 63df63ebfb24..d4174d508cbf 100644 > --- a/net/bluetooth/hci_debugfs.c > +++ b/net/bluetooth/hci_debugfs.c > @@ -88,6 +88,9 @@ static int __name ## _show(struct seq_file *f, void *ptr) \ > return 0; \ > } \ > \ > +DEFINE_SHOW_ATTRIBUTE(__name) eh? > +> +#define DEFINE_SHOW_ATTRIBUTE(__name) \ > static int __name ## _open(struct inode *inode, struct file *file) \ > { \ > return single_open(file, __name ## _show, inode->i_private); \ -- ~Randy
Powered by blists - more mailing lists