netdev - Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

Open Source and information security mailing list archives

Message-ID: <CA+sq2Ce+Qx=ouzieFLBQBhyhMMduzvQKu-iV837njnEMuCdWyg@mail.gmail.com>
Date:   Thu, 23 Nov 2017 09:49:36 +0530
From:   Sunil Kovvuri <sunil.kovvuri@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Aleksey Makarov <aleksey.makarov@...iga.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Robert Richter <rric@...nel.org>,
        Aleksey Makarov <aleksey.makarov@...ium.com>,
        "Goutham, Sunil" <Sunil.Goutham@...ium.com>,
        Florian Westphal <fw@...len.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Sunil Goutham <sgoutham@...ium.com>,
        LAKML <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

On Wed, Nov 22, 2017 at 9:27 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Wed, 2017-11-22 at 15:37 +0300, Aleksey Makarov wrote:
>> From: Sunil Goutham <sgoutham@...ium.com>
>>
>> This fixes a previous patch which missed some changes
>> and due to which L3 checksum offload was getting enabled
>> for IPv6 pkts. And HW is dropping these pkts as it assumes
>> the pkt is IPv4 when IP csum offload is set in the SQ
>> descriptor.
>>
>> Fixes: bbbb494fd005 ("net: thunderx: Enable TSO and checksum offloads
>> for ipv6")
>> Signed-off-by: Sunil Goutham <sgoutham@...ium.com>
>> Signed-off-by: Aleksey Makarov <aleksey.makarov@...iga.com>
>> ---
>>  drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
>> b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
>> index d4496e9afcdf..184d5bdbe7e0 100644
>> --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
>> +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
>> @@ -1355,10 +1355,11 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic,
>> struct snd_queue *sq, int qentry,
>>
>>       /* Offload checksum calculation to HW */
>>       if (skb->ip_summed == CHECKSUM_PARTIAL) {
>> -             hdr->csum_l3 = 1; /* Enable IP csum calculation */
>>               hdr->l3_offset = skb_network_offset(skb);
>>               hdr->l4_offset = skb_transport_offset(skb);
>>
>> +             /* Enable IP HDR csum calculation for V4 pkts */
>> +             hdr->csum_l3 = (ip.v4->version == 4) ? 1 : 0;
>
> Have you tried to set hdr->csum_l3 to 0 regardless of version being 4
> or 6 ?
>
> This would remove the need for yet another conditional.
>
> AFAIK, linux does not offload IPv4 header checksums to NIC, it is not
> worth the trouble.

Looks like I misunderstood the IPSUM netdev feature flag.
Thanks, will check.

Sunil.

>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives