netdev - Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171123133526.393b5aa5@elisabeth>
Date:   Thu, 23 Nov 2017 13:35:26 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Eric Garver <e@...g.me>,
        Pravin B Shelar <pshelar@....org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX
 info when CONFIG_IPV6

On Thu, 23 Nov 2017 11:27:24 +0800
Hangbin Liu <liuhangbin@...il.com> wrote:

> Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't
> make sense if we haven't enabled CONFIG_IPV6. Fix it by adding
> if IS_ENABLED(CONFIG_IPV6) check.

Thanks for fixing this. I would add:

Suggested-by: Stefano Brivio <sbrivio@...hat.com>
Fixes: abe492b4f50c ("geneve: UDP checksum configuration via netlink")
Fixes: fd7eafd02121 ("geneve: fix fill_info when link down")

> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano