netdev - Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Nov 2017 15:03:30 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Oliver Graute <oliver.graute@...il.com>
Cc:     netdev@...r.kernel.org, Oliver Graute <oliver.graute@...haus.de>
Subject: Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

Oliver Graute <oliver.graute@...il.com> writes:

>     When the PLS8 devices show up with PID 0x0061 they will expose both a
>     QMI port and a WWAN interface.

Please remove the indentation.

> Signed-off-by: Oliver Graute <oliver.graute@...haus.de>
> ---
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 720a3a2..b7ee59d 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1221,6 +1221,7 @@ static int qmi_wwan_resume(struct usb_interface *intf)
>  	{QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)},	/* Olivetti Olicard 160 */
>  	{QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},	/* Olivetti Olicard 500 */
>  	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
> +	{QMI_FIXED_INTF(0x1e2d, 0x0061, 3)},	/* Cinterion PLS8 */
>  	{QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},	/* Cinterion PHxx,PXxx */
>  	{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},	/* Cinterion PHxx,PXxx (2 RmNet) */
>  	{QMI_FIXED_INTF(0x1e2d, 0x0082, 5)},	/* Cinterion PHxx,PXxx (2 RmNet) */

Are you sure this is correct? The Windows drivers I found for this
device appear to think all functions use even interface numbers only,
presumably because of a control+data interface layout?

And the first 5 functions are supposedly all serial:

[Strings]
VENDOR_NAME          = "Gemalto M2M GmbH"
SRC_DSK              = "Gemalto M2M GmbH ALSx PLSx LTE USB Driver Disk"
DEVICE_NAME          = "Gemalto M2M ALSx PLSx LTE USB Modem"
SERVICE_DISPLAY_NAME = "Gemalto M2M ALSx PLSx LTE USB Modem Device"
USB_VID              = "VID_1E2D"
USB_PID              = "PID_0061"
..
[Models]
%DEVICE_NAME% = Modem,USB\%USB_VID%&%USB_PID%&MI_00

[Strings]
VENDOR_NAME          = "Gemalto M2M GmbH"
SRC_DSK              = "Gemalto M2M GmbH ALSx PLSx LTE USB Driver Disk"
DEVICE_NAME_1        = "Gemalto M2M ALSx PLSx LTE USB serial Port 1"
DEVICE_NAME_2        = "Gemalto M2M ALSx PLSx LTE USB serial Port 2"
DEVICE_NAME_3        = "Gemalto M2M ALSx PLSx LTE USB serial Port 3"
DEVICE_NAME_4        = "Gemalto M2M ALSx PLSx LTE USB serial Port 4"
SERVICE_DISPLAY_NAME = "Gemalto M2M ALSx PLSx LTE USB Device for serial Communication"
USB_VID              = "VID_1E2D"
USB_PID              = "PID_0061"
..
[SerialPort]
%DEVICE_NAME_1%=PortInstall, USB\%USB_VID%&%USB_PID%&MI_02
%DEVICE_NAME_2%=PortInstall, USB\%USB_VID%&%USB_PID%&MI_04
%DEVICE_NAME_3%=PortInstall, USB\%USB_VID%&%USB_PID%&MI_06
%DEVICE_NAME_4%=PortInstall, USB\%USB_VID%&%USB_PID%&MI_08

The network functions should be on interfaces 10 and 12 according to
this driver info:

[Strings]
VENDOR_NAME          = "Gemalto M2M GmbH"
SRC_DSK              = "Gemalto M2M GmbH ALSx PLSx LTE USB Driver Disk"
DEVICE_NAME_1        = "Gemalto M2M ALSx PLSx LTE USB MB Wireless Ethernet Adapter"
DEVICE_NAME_2        = "Gemalto M2M ALSx PLSx LTE USB MB Wireless Ethernet Adapter (2nd context)"
SERVICE_DISPLAY_NAME = "Gemalto M2M ALSx PLSx LTE USB MB NDIS Miniport"
USB_VID              = "VID_1E2D"
USB_PID              = "PID_0061"
..
[Models.NTx86.6.1]
%DEVICE_NAME_1%=wwan.NTx86.6.1,USB\%USB_VID%&%USB_PID%&MI_0A
%DEVICE_NAME_2%=wwan.NTx86.6.1,USB\%USB_VID%&%USB_PID%&MI_0C

But I don't know anything about this device.  Maybe the layout is
configurable without changing the device ID?  Do you have any more
information you can provide, like for example a verbose lsusb output or
the relevant part of /sys/kernel/debug/usb/devices?

Bjørn