netdev - Re: [PATCH net] ipv6: Do not consider linkdown nexthops during multipath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171124.012723.1606817313489376114.davem@davemloft.net>
Date:   Fri, 24 Nov 2017 01:27:23 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com, andy@...yhouse.net,
        mlxsw@...lanox.com
Subject: Re: [PATCH net] ipv6: Do not consider linkdown nexthops during
 multipath

From: Ido Schimmel <idosch@...lanox.com>
Date: Tue, 21 Nov 2017 09:50:12 +0200

> When the 'ignore_routes_with_linkdown' sysctl is set, we should not
> consider linkdown nexthops during route lookup.
> 
> While the code correctly verifies that the initially selected route
> ('match') has a carrier, it does not perform the same check in the
> subsequent multipath selection, resulting in a potential packet loss.
> 
> In case the chosen route does not have a carrier and the sysctl is set,
> choose the initially selected route.
> 
> Fixes: 35103d11173b ("net: ipv6 sysctl option to ignore routes when nexthop link is down")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied.