netdev - Re: [PATCH iproute2 1/1] actions: Add support for user cookies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171123163612.GA2040@nanopsycho>
Date:   Thu, 23 Nov 2017 17:36:12 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/1] actions: Add support for user cookies

Sat, Apr 22, 2017 at 02:36:23PM CEST, jhs@...atatu.com wrote:

[...]

>@@ -274,8 +302,17 @@ tc_print_one_action(FILE *f, struct rtattr *arg)
> 		return err;
> 
> 	if (show_stats && tb[TCA_ACT_STATS]) {
>+
> 		fprintf(f, "\tAction statistics:\n");
> 		print_tcstats2_attr(f, tb[TCA_ACT_STATS], "\t", NULL);
>+		if (tb[TCA_ACT_COOKIE]) {
>+			int strsz = RTA_PAYLOAD(tb[TCA_ACT_COOKIE]);
>+			char b1[strsz+1];
>+
>+			fprintf(f, "\n\tcookie len %d %s ", strsz,
>+				hexstring_n2a(RTA_DATA(tb[TCA_ACT_COOKIE]),
>+					      strsz, b1, sizeof(b1)));
>+		}


Jamal, is there any particular reason that you print cookie only in case
you show stats? What is the relation between cookie and stats?



> 		fprintf(f, "\n");
> 	}
> 
>-- 
>1.9.1
>