netdev - Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171124022826.GA32569@lunn.ch>
Date:   Fri, 24 Nov 2017 03:28:26 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Arend Van Spriel <arend.vanspriel@...adcom.com>
Cc:     "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF

On Thu, Nov 23, 2017 at 08:27:48PM +0100, Arend Van Spriel wrote:
> + Arnd
> 
> On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel
> <arend.vanspriel@...adcom.com> wrote:
> > On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn <andrew@...n.ch> wrote:
> >> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote:
> >>> Compilation fails building on x86_64 platform which does not
> >>> have CONFIG_OF enabled.
> >>>
> >>> Signed-off-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> >>> ---
> >>> After rebasing my branch to v4.14 I attempted to build the kernel and hit
> >>> the following compile issue:
> >>>
> >>> net/dsa/dsa2.c: In function \u2018dsa_switch_parse_member_of\u2019:
> >>> net/dsa/dsa2.c:678:2: error: implicit declaration of function
> >>> 'of_property_read_variable_u32_array'
> >>
> >> Hi Arend
> >>
> >> https://lkml.org/lkml/2017/11/6/493
> >
> > So my email/patch did get through initially. Sorry for the noise and
> > thanks for the info.
> 
> Hi Andrew,
> 
> Getting back to this. It seems that this patch did not get in. At
> least I searched for it in v4.14.1 but no luck.

Hi Arned

The use of of_property_read_variable_u32_array was added in
975e6e32215e ("net: dsa: rework switch parsing"). This patch is not in
v4.14. It is in linus/master, so v4.15-rc1 should have it. And the fix
is also in linus/master.

So there does not appear to be anything wrong. I just built v4.14.1
for x86_64 with DSA without problems.

   Andrew