netdev - Re: [PATCH net v3] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171125.235454.1853975778488578912.davem@davemloft.net>
Date:   Sat, 25 Nov 2017 23:54:54 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     aleksey.makarov@...iga.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sunil.Goutham@...ium.com, rric@...nel.org, fw@...len.de,
        eric.dumazet@...il.com, aleksey.makarov@...ium.com,
        sgoutham@...ium.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net v3] net: thunderx: Fix TCP/UDP checksum offload for
 IPv6 pkts

From: Aleksey Makarov <aleksey.makarov@...iga.com>
Date: Thu, 23 Nov 2017 22:34:31 +0300

> From: Sunil Goutham <sgoutham@...ium.com>
> 
> Don't offload IP header checksum to NIC.
> 
> This fixes a previous patch which enabled checksum offloading
> for both IPv4 and IPv6 packets.  So L3 checksum offload was
> getting enabled for IPv6 pkts.  And HW is dropping these pkts
> as it assumes the pkt is IPv4 when IP csum offload is set
> in the SQ descriptor.
> 
> Fixes:  3a9024f52c2e ("net: thunderx: Enable TSO and checksum offloads for ipv6")
> Signed-off-by: Sunil Goutham <sgoutham@...ium.com>
> Signed-off-by: Aleksey Makarov <aleksey.makarov@...iga.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Applied.