netdev - RE: [PATCH] r8152: disable rx checksum offload on Dell TB dock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <781f649709244a7491371e3b6e436d68@ausx13mpc120.AMER.DELL.COM>
Date:   Mon, 27 Nov 2017 15:11:24 +0000
From:   <Mario.Limonciello@...l.com>
To:     <kai.heng.feng@...onical.com>, <gregkh@...uxfoundation.org>
CC:     <davem@...emloft.net>, <hayeswang@...ltek.co>,
        <linux-usb@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> -----Original Message-----
> From: Kai Heng Feng [mailto:kai.heng.feng@...onical.com]
> Sent: Friday, November 24, 2017 3:00 AM
> To: Greg KH <gregkh@...uxfoundation.org>
> Cc: David Miller <davem@...emloft.net>; hayeswang@...ltek.co; linux-
> usb@...r.kernel.org; netdev@...r.kernel.org; LKML <linux-
> kernel@...r.kernel.org>; Limonciello, Mario <Mario_Limonciello@...l.com>
> Subject: Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock
> 
> 
> > Also the MAC address is different, can you just trigger off of Dell's
> > MAC address space instead of the address space of the dongle device?
> 
> A really good idea, never thought of this. Thanks for the hint :)
> Still, I need to ask Dell folks to get all the answers.
> 
> Kai-Heng

The MAC address stuff is workable to tell if it's a r8153-AD (which is in Dell Inc Type C
dongles,  TB16 and WD15 docks).

This alone wouldn't be enough to tell if it's a TB16.  I believe you'd need to have an
extra check for that, but maybe this workaround can run after you verify it's r8153-AD
in the special MAC address handling section of r8153 driver.