netdev - Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17004.1511808959@warthog.procyon.org.uk>
Date:   Mon, 27 Nov 2017 18:55:59 +0000
From:   David Howells <dhowells@...hat.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     dhowells@...hat.com, "David S. Miller" <davem@...emloft.net>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

Gustavo A. R. Silva <garsilva@...eddedor.com> wrote:

> Value assigned to variable resend_at is overwritten before it can be used.
> 
> Fix this by removing the value overwrite as it seems that this is a
> leftover code.

NAK.  Your fix will actually cause the code to break.

The resend_at value used for the timer must be based on the current time
(ie. jiffies in this case), so we can't simply remove that line as the
previously calculated resend_at value is a duration, not a time.

What you need to do is to instead modify the line you wanted to remove to add
'now' to the previously-computed value.

David