netdev - Re: [PATCH iproute2] tc: police: fix control action parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171127123259.324f20cf@xeon-e3>
Date:   Mon, 27 Nov 2017 12:32:59 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Michal Privoznik <mprivozn@...hat.com>
Cc:     netdev@...r.kernel.org, jiri@...lanox.com
Subject: Re: [PATCH iproute2] tc: police: fix control action parsing

On Mon, 27 Nov 2017 19:00:14 +0100
Michal Privoznik <mprivozn@...hat.com> wrote:

> parse_action_control helper does advancing of the arg inside. So don't
> do it outside.
> 
> Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions")
> Signed-off-by: Michal Privoznik <mprivozn@...hat.com>

The helpers are not helping here.
Adding another layer of indirection on moving argc/argv then causing caller
to have to keep track is bad design.

Also since pars_action_control_slash is only used by police, why was it
moved into tc_util in the first place? I would prefer just to rip out that
bit and put it back in policer.