netdev - Re: [PATCH v2 net] net/packet: fix a race in packet_bind() and packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171128.111443.180500540219983749.davem@davemloft.net>
Date:   Tue, 28 Nov 2017 11:14:43 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, fruggeri@...stanetworks.com,
        willemb@...gle.com
Subject: Re: [PATCH v2 net] net/packet: fix a race in packet_bind() and
 packet_notifier()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 28 Nov 2017 08:03:30 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> syzbot reported crashes [1] and provided a C repro easing bug hunting.
> 
> When/if packet_do_bind() calls __unregister_prot_hook() and releases
> po->bind_lock, another thread can run packet_notifier() and process an
> NETDEV_UP event.
> 
> This calls register_prot_hook() and hooks again the socket right before
> first thread is able to grab again po->bind_lock.
> 
> Fixes this issue by temporarily setting po->num to 0, as suggested by
> David Miller.
> 
> [1]
 ...
> Fixes: 30f7ea1c2b5f ("packet: race condition in packet_bind")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Cc: Francesco Ruggeri <fruggeri@...stanetworks.com>

Applied and queued up for -stable.