netdev - Re: [PATCH net] sch_sfq: fix null pointer dereference at timer expiration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJdCH-3Z_wMYh1dDAqsk7YC+fYo2rrAFOvJc9NNKwu3Jw@mail.gmail.com>
Date:   Tue, 28 Nov 2017 12:16:55 -0800
From:   Kees Cook <keescook@...omium.org>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     Paolo Abeni <pabeni@...hat.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH net] sch_sfq: fix null pointer dereference at timer expiration

On Tue, Nov 28, 2017 at 9:50 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Tue, Nov 28, 2017 at 5:28 AM, Paolo Abeni <pabeni@...hat.com> wrote:
>> While converting sch_sfq to use timer_setup(), the commit cdeabbb88134
>> ("net: sched: Convert timers to use timer_setup()") forgot to
>> initialize the 'sch' field. As a result, the timer callback tries to
>> dereference a NULL pointer, and the kernel does oops.
>>
>> Fix it initializing such field at qdisc creation time.
>>
>> Fixes: cdeabbb88134 ("net: sched: Convert timers to use timer_setup()")
>> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
>
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks for the catch! Yup, this was a goof on my end (all other timers
correctly initialize that value, but the one in sfq_init() got
missed). Thanks!

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Pixel Security