[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20171128.155619.1927237670822390286.davem@davemloft.net>
Date: Tue, 28 Nov 2017 15:56:19 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: lucien.xin@...il.com
Cc: netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
marcelo.leitner@...il.com, nhorman@...driver.com
Subject: Re: [PATCH net] sctp: use right member as the param of
list_for_each_entry
From: Xin Long <lucien.xin@...il.com>
Date: Sun, 26 Nov 2017 20:56:07 +0800
> Commit d04adf1b3551 ("sctp: reset owner sk for data chunks on out queues
> when migrating a sock") made a mistake that using 'list' as the param of
> list_for_each_entry to traverse the retransmit, sacked and abandoned
> queues, while chunks are using 'transmitted_list' to link into these
> queues.
>
> It could cause NULL dereference panic if there are chunks in any of these
> queues when peeling off one asoc.
>
> So use the chunk member 'transmitted_list' instead in this patch.
>
> Fixes: d04adf1b3551 ("sctp: reset owner sk for data chunks on out queues when migrating a sock")
> Signed-off-by: Xin Long <lucien.xin@...il.com>
Applied and queued up for -stable.
Powered by blists - more mailing lists