netdev - Re: [patch net resend] net: sched: cbq: create block for q->link.block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171128.160508.1295620750789223277.davem@davemloft.net>
Date:   Tue, 28 Nov 2017 16:05:08 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        mlxsw@...lanox.com, jaster@...hat.com, ivecera@...hat.com
Subject: Re: [patch net resend] net: sched: cbq: create block for
 q->link.block

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 27 Nov 2017 18:37:21 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> q->link.block is not initialized, that leads to EINVAL when one tries to
> add filter there. So initialize it properly.
> 
> This can be reproduced by:
> $ tc qdisc add dev eth0 root handle 1: cbq avpkt 1000 rate 1000Mbit bandwidth 1000Mbit
> $ tc filter add dev eth0 parent 1: protocol ip prio 100 u32 match ip protocol 0 0x00 flowid 1:1
> 
> Reported-by: Jaroslav Aster <jaster@...hat.com>
> Reported-by: Ivan Vecera <ivecera@...hat.com>
> Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable, thanks Jiri.