netdev - Re: [PATCH] atm: eni: fix several indentation issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2017 21:54:27 -0800
From:   Joe Perches <joe@...ches.com>
To:     Colin King <colin.king@...onical.com>,
        Chas Williams <3chas3@...il.com>,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: eni: fix several indentation issues

On Mon, 2017-11-27 at 13:15 +0000, Colin King wrote:
> drivers/atm/eni.c

Aren't all those ++ variables unused?

They seem to be emitted in an
#if 0
	printk(...)
#endif

Maybe these should be removed or changed
to something like:

#if 0
#define DEBUG_INCR(var) do { (var)++ } while (0)
#else
#define DEBUG_INCR(var) do {} while (0)
#endif

...

	DEBUG_INCR(rx_enqueued);