netdev - RE: [RFC] Support for SGMII 2500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR04MB124132A66D9E276F15D354C3973A0@HE1PR04MB1241.eurprd04.prod.outlook.com>
Date:   Tue, 28 Nov 2017 08:16:28 +0000
From:   Prabhakar Kushwaha <prabhakar.kushwaha@....com>
To:     Bhaskar Upadhaya <bhaskar.upadhaya@....com>,
        Madalin-cristian Bucur <madalin.bucur@....com>,
        Andrew Lunn <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Anji Jagarlmudi <anji.jagarlmudi@....com>,
        Calvin Johnson <calvin.johnson@....com>,
        Poonam Aggrwal <poonam.aggrwal@....com>
CC:     Shengzhou Liu <shengzhou.liu@....com>, York Sun <york.sun@....com>,
        "u-boot@...ts.denx.de" <u-boot@...ts.denx.de>
Subject: RE: [RFC] Support for SGMII 2500

Hi Madalin,

> -----Original Message-----
> From: Bhaskar Upadhaya
> Sent: Tuesday, November 28, 2017 12:57 PM
> To: Madalin-cristian Bucur <madalin.bucur@....com>; Andrew Lunn
> <andrew@...n.ch>; f.fainelli@...il.com; netdev@...r.kernel.org; Anji
> Jagarlmudi <anji.jagarlmudi@....com>; Calvin Johnson
> <calvin.johnson@....com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@....com>; Poonam Aggrwal
> <poonam.aggrwal@....com>
> Cc: Shengzhou Liu <shengzhou.liu@....com>; York Sun <york.sun@....com>; u-
> boot@...ts.denx.de
> Subject: RE: [RFC] Support for SGMII 2500
> 
> + Anji, Calvin, Prabhakar, Poonam.
> 
> -----Original Message-----
> From: Madalin-cristian Bucur
> Sent: Tuesday, November 28, 2017 12:56 PM
> To: Andrew Lunn <andrew@...n.ch>; f.fainelli@...il.com;
> netdev@...r.kernel.org
> Cc: Bhaskar Upadhaya <bhaskar.upadhaya@....com>; Shengzhou Liu
> <shengzhou.liu@....com>; York Sun <york.sun@....com>; u-
> boot@...ts.denx.de
> Subject: [RFC] Support for SGMII 2500
> 
> Hi,
> 
> There is a disconnect between the SGMII 2500 support in u-boot and Linux.
> Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps by
> using the PHY connection type "sgmii-2500" in the device tree:
> 
> 	phy-connection-type = "sgmii-2500";
> 
> This is supported by u-boot, in include/phy.h:
> 
> 	typedef enum {
> 	        PHY_INTERFACE_MODE_MII,
> 	        PHY_INTERFACE_MODE_GMII,
> 	        PHY_INTERFACE_MODE_SGMII,
> 	        PHY_INTERFACE_MODE_SGMII_2500,
> 	...
> 
> 	static const char *phy_interface_strings[] = {
> 	        [PHY_INTERFACE_MODE_MII]                = "mii",
> 	        [PHY_INTERFACE_MODE_GMII]               = "gmii",
> 	        [PHY_INTERFACE_MODE_SGMII]              = "sgmii",
> 	        [PHY_INTERFACE_MODE_SGMII_2500]         = "sgmii-2500",
> 	...
> 
> since this commit:
> 
> 	commit c35f8693942d8284c635592f263a0fe11abe1d1d
> 	Author: Shengzhou Liu <Shengzhou.Liu@...escale.com>
> 	Date:   Thu Oct 23 17:20:57 2014 +0800
> 
> 	    net/fm: add 2.5G SGMII support
> 
> 	    As auto-negotiation is not supported for 2.5G SGMII, we need
> 	    to add a new type PHY_INTERFACE_MODE_SGMII_2500 to
> differentiate
> 	    SGMII-1G and SGMII-2.5G with different setting for auto-negotiation.
> 
> 	    Signed-off-by: Shaohui Xie <Shaohui.Xie@...escale.com>
> 	    Signed-off-by: Shengzhou Liu <Shengzhou.Liu@...escale.com>
> 	    Reviewed-by: York Sun <yorksun@...escale.com>
> 
> In the Linux kernel we do not have a separate define for SGMII_2500, should we
> add something like the change below?
> 

If there is no separate define in Linux. Than how it deals with auto-negotiation.
Can same approach be used in u-boot?

--pk