netdev - Re: [PATCH net] net: phy: marvell10g: fix the PHY id mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171128134358.GC20797@lunn.ch>
Date:   Tue, 28 Nov 2017 14:43:58 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Antoine Tenart <antoine.tenart@...e-electrons.com>
Cc:     rmk@...linux.org.uk, f.fainelli@...il.com, davem@...emloft.net,
        gregory.clement@...e-electrons.com,
        thomas.petazzoni@...e-electrons.com,
        miquel.raynal@...e-electrons.com, nadavh@...vell.com,
        mw@...ihalf.com, stefanc@...vell.com, ymarkman@...vell.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: marvell10g: fix the PHY id mask

On Tue, Nov 28, 2017 at 02:26:30PM +0100, Antoine Tenart wrote:
> The Marvell 10G PHY driver supports different hardware revisions, which
> have their bits 3..0 differing. To get the correct revision number these
> bits should be ignored. This patch fixes this by using the already
> defined MARVELL_PHY_ID_MASK (0xfffffff0) instead of the custom
> 0xffffffff mask.
> 
> Fixes: 20b2af32ff3f ("net: phy: add Marvell Alaska X 88X3310 10Gigabit PHY support")
> Suggested-by: Yan Markman <ymarkman@...vell.com>
> Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew