lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Nov 2017 14:56:10 +0100 From: Andrew Lunn <andrew@...n.ch> To: Antoine Tenart <antoine.tenart@...e-electrons.com> Cc: rmk@...linux.org.uk, f.fainelli@...il.com, davem@...emloft.net, Yan Markman <ymarkman@...vell.com>, gregory.clement@...e-electrons.com, thomas.petazzoni@...e-electrons.com, miquel.raynal@...e-electrons.com, nadavh@...vell.com, mw@...ihalf.com, stefanc@...vell.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] net: phylink: fix link state on phy-connect > + /* On _disconnect, the phy state machine and phylink resolve > + * are stopped before executing full gracefull down/reset state. > + * The further _connect starts with incorrect init state. Let's set > + * init values here. > + */ > + pl->phy_state.link = false; > + pl->link_config.pause = MLO_PAUSE_AN; > + pl->link_config.speed = SPEED_UNKNOWN; > + pl->link_config.duplex = DUPLEX_UNKNOWN; Hi Antoine Looks sensible. My only comment would be, maybe it makes sense to reduce the duplication by adding a little helper which is called here, and in phylink_create()? Andrew
Powered by blists - more mailing lists