netdev - Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171128145530.GA23377@orbyte.nwl.cc>
Date:   Tue, 28 Nov 2017 15:55:30 +0100
From:   Phil Sutter <phil@....cc>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, daniel@...earbox.net,
        alexei.starovoitov@...il.com, jiri@...nulli.us,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [RFC net-next 4/6] netdevsim: add software driver for testing
 offloads

Hi,

On Mon, Nov 27, 2017 at 11:42:49AM -0800, Jakub Kicinski wrote:
> On Tue, 28 Nov 2017 04:30:26 +0900 (KST), David Miller wrote:
> > From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> > Date: Thu, 23 Nov 2017 18:36:11 -0800
> > 
> > > The dummy driver have previously been extended to test SR-IOV,
> > > but the general consensus seems to be against adding further
> > > features to it.  
> > 
> > I guess this is fine, but then is it going to be the case that
> > every time we want to add a software offload implementation for
> > testing driver paths we add yet another dummy driver?
> 
> I would expect others to extend the netdevsim driver, so all test/SW
> implementation would live there.
> 
> I was considering moving the SR-IOV code over, too, but I'm worried  
> I will break existing tests.  Phil, Sabrina would you be OK with that?

Yes, that's fine with us!

Thanks, Phil