netdev - Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171129.113549.1990396476364963247.davem@davemloft.net>
Date:   Wed, 29 Nov 2017 11:35:49 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     willy@...radead.org
Cc:     kubakici@...pl, mawilcox@...rosoft.com, chrism@...lanox.com,
        jiri@...lanox.com, xiyou.wangcong@...il.com, jhs@...atatu.com,
        daniel@...earbox.net, ebiggers@...gle.com, laijs@...fujitsu.com,
        tj@...nel.org, aquannie@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

From: Matthew Wilcox <willy@...radead.org>
Date: Wed, 29 Nov 2017 08:29:16 -0800

> On Tue, Nov 28, 2017 at 05:08:40PM -0800, Jakub Kicinski wrote:
>> On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:
>> > +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
>> > +						INT_MAX, GFP_KERNEL);
>> > +	} else if (!oldprog) {
>> > +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
>> > +						handle, GFP_KERNEL);
>> 
>> nit: in many places you seem to not align the second line with opening
>> parenthesis.  Is that intentional?
> 
> It's more that I don't care.  I press 'enter', which indents the arguments
> by a certain amount, then press the 'tab' key until it looks aesthetically
> pleasing.
> 
>> FWIW there may be a small merge conflict with net on cls_bpf in patch
>> 5, some of the code has been removed.
> 
> Thanks.  Dave, do you want to take the IDR patches through your tree to
> save conflict resolution?

Sure, after you fix the indentation problems Jakub pointed out please
resubmit them separately to netdev.