netdev - Re: [Patch net v2] act_sample: get rid of tcf_sample_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512011484.19682.8.camel@gmail.com>
Date:   Wed, 29 Nov 2017 19:11:24 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        Yotam Gigi <yotamg@...lanox.com>
Subject: Re: [Patch net v2] act_sample: get rid of tcf_sample_cleanup_rcu()

On Wed, 2017-11-29 at 16:07 -0800, Cong Wang wrote:
> Similar to commit d7fb60b9cafb ("net_sched: get rid of tcfa_rcu"),
> TC actions don't need to respect RCU grace period, because it
> is either just detached from tc filter (standalone case) or
> it is removed together with tc filter (bound case) in which case
> RCU grace period is already respected at filter layer.
> 
> Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action")
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Cc: Yotam Gigi <yotamg@...lanox.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  include/net/tc_act/tc_sample.h |  1 -
>  net/sched/act_sample.c         | 14 +++-----------
>  2 files changed, 3 insertions(+), 12 deletions(-)
> 

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !