netdev - Re: [iproute PATCH] link_gre6: Detect invalid encaplimit values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f8269be-363c-7f57-31cb-72f58495c68a@6wind.com>
Date:   Thu, 30 Nov 2017 14:02:50 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Phil Sutter <phil@....cc>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute PATCH] link_gre6: Detect invalid encaplimit values

Le 28/11/2017 à 16:49, Phil Sutter a écrit :
> Looks like a typo: get_u8() returns 0 on success and -1 on error, so the
> error checking here was ineffective.
> 
> Fixes: a11b7b71a6eba ("link_gre6: really support encaplimit option")
> Signed-off-by: Phil Sutter <phil@....cc>
Good catch!

Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>