netdev - Re: [PATCH 3/3] make sock_alloc_file() do sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512120836.19682.33.camel@gmail.com>
Date:   Fri, 01 Dec 2017 01:33:56 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Al Viro <viro@...IV.linux.org.uk>, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] make sock_alloc_file() do sock_release() on failures

On Fri, 2017-12-01 at 00:23 +0000, Al Viro wrote:
> This changes calling conventions (and simplifies the hell out
> the callers).  New rules: once struct socket had been passed
> to sock_alloc_file(), it's been consumed either by struct file
> or by sock_release() done by sock_alloc_file().  Either way
> the caller should not do sock_release() after that point.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---

Nice cleanup !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>