netdev - Re: [Patch net-next] act_mirred: get rid of mirred_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpX5PQKBd-derD50HBi4Bu=sNTHFAdd0b-JNi9K_X1ZHDw@mail.gmail.com>
Date:   Thu, 30 Nov 2017 17:02:38 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net-next] act_mirred: get rid of mirred_list_lock spinlock

On Thu, Nov 30, 2017 at 3:12 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2017-11-30 at 14:53 -0800, Cong Wang wrote:
>> @@ -55,13 +54,10 @@ static void tcf_mirred_release(struct tc_action
>> *a, int bind)
>>       struct tcf_mirred *m = to_mirred(a);
>>       struct net_device *dev;
>>
>> -     /* We could be called either in a RCU callback or with RTNL
>> lock held. */
>> -     spin_lock_bh(&mirred_list_lock);
>>       list_del(&m->tcfm_list);
>>       dev = rcu_dereference_protected(m->tcfm_dev, 1);
>
> If RTNL is held at this point, I suggest to use
> rtnl_dereference() instead of rcu_dereference_protected() to get proper
> lockdep coverage.

Ah, sure, I missed it. Will send v2 later.