netdev - Re: [PATCH net-next resubmit 1/2] net: phy: core: use genphy version of callbacks read_status and config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171201.154233.1577368959365305544.davem@davemloft.net>
Date:   Fri, 01 Dec 2017 15:42:33 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next resubmit 1/2] net: phy: core: use genphy
 version of callbacks read_status and config_aneg per default

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 30 Nov 2017 23:46:19 +0100

> read_status and config_aneg are the only mandatory callbacks and most
> of the time the generic implementation is used by drivers.
> So make the core fall back to the generic version if a driver doesn't
> implement the respective callback.
> 
> Also currently the core doesn't seem to verify that drivers implement
> the mandatory calls. If a driver doesn't do so we'd just get a NPE.
> With this patch this potential issue doesn't exit any longer.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Applied.