netdev - Re: [PATCH net v2 1/3] xfrm: Fix xfrm_input() to verify state is valid when (encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201070430.bhhl4yykzpcxkzel@gauss3.secunet.de>
Date:   Fri, 1 Dec 2017 08:04:30 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <avivh@...lanox.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        Boris Pismenny <borisp@...lanox.com>,
        Yossi Kuperman <yossiku@...lanox.com>,
        "Yevgeny Kliteynik" <kliteyn@...lanox.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2 1/3] xfrm: Fix xfrm_input() to verify state is
 valid when (encap_type < 0)

On Tue, Nov 28, 2017 at 07:55:40PM +0200, avivh@...lanox.com wrote:
> From: Aviv Heller <avivh@...lanox.com>
> 
> Code path when (encap_type < 0) does not verify the state is valid
> before progressing.
> 
> This will result in a crash if, for instance, x->km.state ==
> XFRM_STATE_ACQ.
> 
> Fixes: 7785bba299a8 ("esp: Add a software GRO codepath")
> Signed-off-by: Aviv Heller <avivh@...lanox.com>
> Signed-off-by: Yevgeny Kliteynik <kliteyn@...lanox.com>

Good catch!

Patch applied, thanks Aviv!