netdev - Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171202065634.GA1821@nanopsycho>
Date:   Sat, 2 Dec 2017 07:56:34 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

Fri, Dec 01, 2017 at 10:46:42PM CET, xiyou.wangcong@...il.com wrote:
>On Fri, Dec 1, 2017 at 9:56 AM, Jiri Pirko <jiri@...nulli.us> wrote:
>>
>> Isn't this here so user may specify a ifindex of netdev which is not yet
>> present on the system (not sure how much sense that would make though...)
>
>How is this even possible? If an ifindex is not present, we return ENODEV:

Right, I missed this. Thanks.

>
>        if (parm->ifindex) {
>                dev = __dev_get_by_index(net, parm->ifindex);
>                if (dev == NULL) {
>                        if (exists)
>                                tcf_idr_release(*a, bind);
>                        return -ENODEV;
>                }