netdev - Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <018f1129-826b-ecd7-9b71-b720706aa930@cogentembedded.com>
Date:   Mon, 4 Dec 2017 20:42:57 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        "David S. Miller" <davem@...emloft.net>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <horms+renesas@...ge.net.au>
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when
 not available

On 12/04/2017 05:13 PM, Thomas Petazzoni wrote:

> Not all variants of the sh_eth hardware have Gigabit
> support. Unfortunately, the current driver doesn't update
> phydev->supported depending on the MAC capabilities. Due to this, if
> you have a Gigabit capable PHY, the PHY will advertise its Gigabit
> capability and establish a link at 1Gbit/s, even though the MAC
> doesn't support it.
> 
> In order to avoid this, we mark phydev->supported if we're running a
> non-Gigabit capable hardware.
> 
> Tested on a SH7786 platform, with a Gigabit PHY.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> ---
>   drivers/net/ethernet/renesas/sh_eth.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index db72d13cebb9..0074c5998481 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1892,6 +1892,11 @@ static int sh_eth_phy_init(struct net_device *ndev)
>   		return PTR_ERR(phydev);
>   	}
>   
> +	/* mask with MAC supported features */
> +	if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
> +		phydev->supported &= PHY_BASIC_FEATURES;
> +	phydev->advertising = phydev->supported;
> +

    Um, looking at this again, I think we have phy_set_max_speed() for that 
kind of stuff now...

[...]

MBR, Sergei