netdev - Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <607df840-613e-b86c-2224-43815b50627c@cogentembedded.com>
Date:   Mon, 4 Dec 2017 23:05:23 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        "David S. Miller" <davem@...emloft.net>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <horms+renesas@...ge.net.au>
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling
 DMA mapping functions

On 12/04/2017 04:33 PM, Thomas Petazzoni wrote:

> There are two types of "struct device": the one representing the
> physical device on its physical bus (platform, SPI, PCI, etc.), and
> the one representing the logical device in its device class (net,
> etc.).
> 
> The DMA mapping API expects to receive as argument a "struct device"
> representing the physical device, as the "struct device" contains
> information about the bus that the DMA API needs.
> 
> However, the sh_eth driver mistakenly uses the "struct device"
> representing the logical device (embedded in "struct net_device")
> rather than the "struct device" representing the physical device on
> its bus.
> 
> This commit fixes that by adjusting all calls to the DMA mapping API.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> ---
>   drivers/net/ethernet/renesas/sh_eth.c | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 7e060aa9fbed..91e918e654fe 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1149,7 +1149,8 @@ static int sh_eth_tx_free(struct net_device *ndev, bool sent_only)
>   			   entry, le32_to_cpu(txdesc->status));
>   		/* Free the original skb. */
>   		if (mdp->tx_skbuff[entry]) {
> -			dma_unmap_single(&ndev->dev, le32_to_cpu(txdesc->addr),
> +			dma_unmap_single(&mdp->pdev->dev,

    Using 'ndev->dev.parent' (as in ravb) also should work... not sure which 
is better (although I'm seeing very strange things in the ravb driver built 
with AArch654 gcc 4.8.5).

[...]

MBR, Sergei