netdev - Re: [PATCH] rtlwifi: rtl818x: remove redundant check for cck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 4 Dec 2017 22:57:55 +0000 (UTC)
From:   Hin-Tak Leung <htl10@...rs.sourceforge.net>
To:     Larry Finger <Larry.Finger@...inger.net>,
        Kalle Valo <kvalo@...eaurora.org>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        Colin King <colin.king@...onical.com>
Cc:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power
 > 15


--------------------------------------------
On Tue, 14/11/17, Colin King <colin.king@...onical.com> wrote:

 
> From: Colin Ian King <colin.king@...onical.com>
 
> cck_poweri cannot be greated than 15 as
> is derived from the bottom 4 bits
> from riv->channels[channel -
> 1].hw_value & 0xf.  Hence the check for it
> being greater than 15 is redundant and
> can be removed.
 
> Detected by CoverityScan, CID#744303
> ("Logically dead code")
 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
 
Acked-by: Hin-Tak Leung <htl10@...rs.sourceforge.net>