netdev - Re: [PATCH net] nfp: fix port stats for mac representors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171205.113006.1417740598020175760.davem@davemloft.net>
Date:   Tue, 05 Dec 2017 11:30:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        pieter.jansenvanvuuren@...ronome.com
Subject: Re: [PATCH net] nfp: fix port stats for mac representors

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Sat, 2 Dec 2017 02:03:31 -0800

> On Fri, Dec 1, 2017 at 9:37 PM, Jakub Kicinski
> <jakub.kicinski@...ronome.com> wrote:
>> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
>>
>> Previously we swapped the tx_packets, tx_bytes and tx_dropped counters
>> with rx_packets, rx_bytes and rx_dropped counters, respectively. This
>> behaviour is correct and expected for VF representors but it should not
>> be swapped for physical port mac representors.
> 
> Ah, I forgot to point the finger.  Should I repost?
> 
> Fixes: eadfa4c3be99 ("nfp: add stats and xmit helpers for representors")

I added this to the commit message, thanks.