netdev - Re: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171205.114833.2112478522356368321.davem@davemloft.net>
Date:   Tue, 05 Dec 2017 11:48:33 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     salil.mehta@...wei.com
Cc:     yisen.zhuang@...wei.com, lipeng321@...wei.com,
        mehta.salil.lnk@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling
 code in HCLGE layer of HNS3 driver

From: Salil Mehta <salil.mehta@...wei.com>
Date: Mon, 4 Dec 2017 01:29:52 +0000

> This patch refactors the code of the reset feature in HCLGE layer
> of HNS3 PF driver. Prime motivation to do this change is: 
> 1. To reduce the time for which common miscellaneous Vector 0
>    interrupt is disabled because of the reset. Simplification
>    of the common miscellaneous interrupt handler routine(for
>    Vector 0) used to handle reset and other sources of Vector
>    0 interrupt.
> 2. Separate the task for handling the reset
> 3. Simplification of reset request submission and pending reset
>    logic.
> 
> 
> To achieve above below few things have been done:
> 1. Interrupt is disabled while common miscellaneous interrupt
>    handler is entered and re-enabled before it is exit. This
>    reduces the interrupt handling latency as compared to older
>    interrupt handling scheme where interrupt was being disabled
>    in interrupt handler context and re-enabled in task context
>    some time later. Made Miscellaneous interrupt handler more
>    generic to handle all sources including reset interrupt source.
> 2. New reset service task has been introduced to service the 
>    reset handling.
> 3. Introduces new reset service task for honoring software reset
>    requests like from network stack related to timeout and serving
>    the pending reset request(to reset the driver and associated
>    clients).
> 
> 
> Change Log:
> Patch V2: Addressed comment by Andrew Lunn
>    Link: https://lkml.org/lkml/2017/12/1/366
> Patch V1: Initial Submit

Series applied, thank you.