netdev - Re: [PATCH net-next] flow_dissector: dissect tunnel info outside __skb_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171205.121002.389030834822163749.davem@davemloft.net>
Date:   Tue, 05 Dec 2017 12:10:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     simon.horman@...ronome.com
Cc:     jiri@...lanox.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
        netdev@...r.kernel.org, oss-drivers@...ronome.com,
        tom@...bertland.com, willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next] flow_dissector: dissect tunnel info outside
 __skb_flow_dissect()

From: Simon Horman <simon.horman@...ronome.com>
Date: Mon,  4 Dec 2017 11:31:48 +0100

> Move dissection of tunnel info to outside of the main flow dissection
> function, __skb_flow_dissect(). The sole user of this feature, the flower
> classifier, is updated to call tunnel info dissection directly, using
> skb_flow_dissect_tunnel_info().
> 
> This results in a slightly less complex implementation of
> __skb_flow_dissect(), in particular removing logic from that call path
> which is not used by the majority of users. The expense of this is borne by
> the flower classifier which now has to make an extra call for tunnel info
> dissection.
> 
> This patch should not result in any behavioural change.
> 
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Ok, let's see where this goes :-)

Applied, thanks.