netdev - Re: [PATCH net-next V3 3/3] net: add a sysctl to make auto flowlabel consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201712050941.cis59LyL%fengguang.wu@intel.com>
Date:   Tue, 5 Dec 2017 10:10:35 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Shaohua Li <shli@...nel.org>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        kafai@...com, eric.dumazet@...il.com, flo@...rcot.fr,
        xiyou.wangcong@...il.com, tom@...bertland.com,
        Shaohua Li <shli@...com>
Subject: Re: [PATCH net-next V3 3/3] net: add a sysctl to make auto flowlabel
 consistent

Hi Shaohua,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Shaohua-Li/net-fix-flowlabel-inconsistency-in-reset-packet/20171205-072626
config: i386-randconfig-x002-12041112 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10:0,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from net//x25/af_x25.c:40:
   include/net/sock.h: In function 'sk_rethink_txhash':
   include/net/sock.h:1753:29: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'?
     if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
                                ^
   include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> include/net/sock.h:1753:2: note: in expansion of macro 'if'
     if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
     ^~
   include/net/sock.h:1753:29: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'?
     if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
                                ^
   include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> include/net/sock.h:1753:2: note: in expansion of macro 'if'
     if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
     ^~
   include/net/sock.h:1753:29: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'?
     if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
                                ^
   include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> include/net/sock.h:1753:2: note: in expansion of macro 'if'
     if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
     ^~

vim +/if +1753 include/net/sock.h

  1748	
  1749	static inline void sk_rethink_txhash(struct sock *sk)
  1750	{
  1751		struct net *net = sock_net(sk);
  1752	
> 1753		if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
  1754			u32 v = prandom_u32();
  1755			sk->sk_txhash = v ?: 1;
  1756		}
  1757	}
  1758	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (34365 bytes)