netdev - Re: [PATCH 1/2] net: sh_eth: add support for SH7786

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171205.151403.1813635509479339757.davem@davemloft.net>
Date:   Tue, 05 Dec 2017 15:14:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sergei.shtylyov@...entembedded.com
Cc:     thomas.petazzoni@...e-electrons.com,
        niklas.soderlund+renesas@...natech.se, geert+renesas@...der.be,
        horms+renesas@...ge.net.au, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/2] net: sh_eth: add support for SH7786

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Tue, 5 Dec 2017 22:49:10 +0300

> On 12/05/2017 10:04 PM, Sergei Shtylyov wrote:
> 
>>>>> This commit adds the sh_eth_cpu_data structure that describes the
>>>>> SH7786 variant of the IP.
>>>>
>>>>      The manual seems to be unavailable, so I have to trust you. :-)
>>>
>>> Yes, sadly. However, if you tell me what to double check, I'd be happy
>>> to do so.
>>     I have the manual now, will check against it...
>>     DaveM, I'm retracting my ACK for the time being.
> 
>    Starting to look into the manual, the current patch is wrong. SH7786
>    SoC was probably the 1st one to use what we thought was R-Car specific
>    register layout. Definite NAK on this version.

Ok.