netdev - Re: [PATCH 0/7 v2] net: Fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4b55643-2f28-d684-0603-83c6f336a23b@cogentembedded.com>
Date:   Tue, 5 Dec 2017 12:54:12 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, wg@...ndegger.com,
        mkl@...gutronix.de, michal.simek@...inx.com, opendmb@...il.com,
        f.fainelli@...il.com, davem@...emloft.net
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 0/7 v2] net: Fix platform_get_irq's error checking

On 12/4/2017 8:48 PM, Arvind Yadav wrote:

> The platform_get_irq() function returns negative number if an error
> occurs, Zero if No irq is found and positive number if irq gets successful.

    No, returning 0 is not a failure indication anymore. It used to be but not 
any longer...

> platform_get_irq() error checking for only zero is not correct.

[...]

MBR, Sergei