lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Dec 2017 15:32:15 +0530 From: Arvind Yadav <arvind.yadav.cs@...il.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, wg@...ndegger.com, mkl@...gutronix.de, michal.simek@...inx.com, opendmb@...il.com, f.fainelli@...il.com, davem@...emloft.net Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org Subject: Re: [PATCH 0/7 v2] net: Fix platform_get_irq's error checking Hi Sergei, On Tuesday 05 December 2017 03:27 PM, Sergei Shtylyov wrote: > On 12/5/2017 12:54 PM, Sergei Shtylyov wrote: > >>> The platform_get_irq() function returns negative number if an error >>> occurs, Zero if No irq is found and positive number if irq gets >>> successful. >> >> No, returning 0 is not a failure indication anymore! It used to >> be but not any longer... > > And I fixed this function exactly to avoid overly complex error > checks (which you're trying to propose here). > Thanks for your comment. yes you are right. Now It'll not return 0. It will return irq and error as negative. I will not add a check for 0. >>> platform_get_irq() error checking for only zero is not correct. >> >> [...] > > MBR, Sergei Thank you, ~arvind
Powered by blists - more mailing lists