netdev - Re: [PATCH net-next 2/2] net: sched: sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af21b4f1-7816-e40e-ce45-8e70971b0b5c@mojatatu.com>
Date:   Tue, 5 Dec 2017 07:30:31 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Alexander Aring <aring@...atatu.com>, davem@...emloft.net
Cc:     xiyou.wangcong@...il.com, jiri@...nulli.us, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 2/2] net: sched: sch_api: rearrange init handling

On 17-12-04 06:40 PM, Alexander Aring wrote:
> This patch fixes the following checkpatch error:
> 
> ERROR: do not use assignment in if condition
> 
> by rearranging the if condition to execute init callback only if init
> callback exists. The whole setup afterwards is called in any case,
> doesn't matter if init callback is set or not. This patch has the same
> behaviour as before, just without assign err variable in if condition.
> It also makes the code easier to read.
> 
> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: David Ahern <dsahern@...il.com>
> Signed-off-by: Alexander Aring <aring@...atatu.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal