netdev - Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171206.140046.1593939441488896213.davem@davemloft.net>
Date:   Wed, 06 Dec 2017 14:00:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     michael.chan@...adcom.com, sathya.perla@...adcom.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] bnxt_en: Uninitialized variable in
 bnxt_tc_parse_actions()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 5 Dec 2017 17:37:52 +0300

> Smatch warns that:
> 
>     drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
>     error: uninitialized symbol 'rc'.
> 
> "rc" is either uninitialized or set to zero here so we can just remove
> the check.
> 
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Michael, please review.

Thanks.